Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: ppapi/proxy/serialized_flash_menu.cc

Issue 1659003003: IPC::Message -> base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more mac fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/proxy/serialized_flash_menu.h ('k') | ppapi/proxy/serialized_var.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/proxy/serialized_flash_menu.h" 5 #include "ppapi/proxy/serialized_flash_menu.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "ipc/ipc_message.h" 9 #include "ipc/ipc_message.h"
10 #include "ppapi/c/private/ppb_flash_menu.h" 10 #include "ppapi/c/private/ppb_flash_menu.h"
11 #include "ppapi/proxy/ppapi_param_traits.h" 11 #include "ppapi/proxy/ppapi_param_traits.h"
12 12
13 namespace ppapi { 13 namespace ppapi {
14 namespace proxy { 14 namespace proxy {
15 15
16 namespace { 16 namespace {
17 // Maximum depth of submenus allowed (e.g., 1 indicates that submenus are 17 // Maximum depth of submenus allowed (e.g., 1 indicates that submenus are
18 // allowed, but not sub-submenus). 18 // allowed, but not sub-submenus).
19 const int kMaxMenuDepth = 2; 19 const int kMaxMenuDepth = 2;
20 const uint32_t kMaxMenuEntries = 1000; 20 const uint32_t kMaxMenuEntries = 1000;
21 21
22 bool CheckMenu(int depth, const PP_Flash_Menu* menu); 22 bool CheckMenu(int depth, const PP_Flash_Menu* menu);
23 void FreeMenu(const PP_Flash_Menu* menu); 23 void FreeMenu(const PP_Flash_Menu* menu);
24 void WriteMenu(IPC::Message* m, const PP_Flash_Menu* menu); 24 void WriteMenu(base::Pickle* m, const PP_Flash_Menu* menu);
25 PP_Flash_Menu* ReadMenu(int depth, 25 PP_Flash_Menu* ReadMenu(int depth,
26 const IPC::Message* m, 26 const base::Pickle* m,
27 base::PickleIterator* iter); 27 base::PickleIterator* iter);
28 28
29 bool CheckMenuItem(int depth, const PP_Flash_MenuItem* item) { 29 bool CheckMenuItem(int depth, const PP_Flash_MenuItem* item) {
30 if (item->type == PP_FLASH_MENUITEM_TYPE_SUBMENU) 30 if (item->type == PP_FLASH_MENUITEM_TYPE_SUBMENU)
31 return CheckMenu(depth, item->submenu); 31 return CheckMenu(depth, item->submenu);
32 return true; 32 return true;
33 } 33 }
34 34
35 bool CheckMenu(int depth, const PP_Flash_Menu* menu) { 35 bool CheckMenu(int depth, const PP_Flash_Menu* menu) {
36 if (depth > kMaxMenuDepth || !menu) 36 if (depth > kMaxMenuDepth || !menu)
37 return false; 37 return false;
38 ++depth; 38 ++depth;
39 39
40 if (menu->count && !menu->items) 40 if (menu->count && !menu->items)
41 return false; 41 return false;
42 42
43 for (uint32_t i = 0; i < menu->count; ++i) { 43 for (uint32_t i = 0; i < menu->count; ++i) {
44 if (!CheckMenuItem(depth, menu->items + i)) 44 if (!CheckMenuItem(depth, menu->items + i))
45 return false; 45 return false;
46 } 46 }
47 return true; 47 return true;
48 } 48 }
49 49
50 void WriteMenuItem(IPC::Message* m, const PP_Flash_MenuItem* menu_item) { 50 void WriteMenuItem(base::Pickle* m, const PP_Flash_MenuItem* menu_item) {
51 PP_Flash_MenuItem_Type type = menu_item->type; 51 PP_Flash_MenuItem_Type type = menu_item->type;
52 m->WriteUInt32(type); 52 m->WriteUInt32(type);
53 m->WriteString(menu_item->name ? menu_item->name : ""); 53 m->WriteString(menu_item->name ? menu_item->name : "");
54 m->WriteInt(menu_item->id); 54 m->WriteInt(menu_item->id);
55 IPC::WriteParam(m, menu_item->enabled); 55 IPC::WriteParam(m, menu_item->enabled);
56 IPC::WriteParam(m, menu_item->checked); 56 IPC::WriteParam(m, menu_item->checked);
57 if (type == PP_FLASH_MENUITEM_TYPE_SUBMENU) 57 if (type == PP_FLASH_MENUITEM_TYPE_SUBMENU)
58 WriteMenu(m, menu_item->submenu); 58 WriteMenu(m, menu_item->submenu);
59 } 59 }
60 60
61 void WriteMenu(IPC::Message* m, const PP_Flash_Menu* menu) { 61 void WriteMenu(base::Pickle* m, const PP_Flash_Menu* menu) {
62 m->WriteUInt32(menu->count); 62 m->WriteUInt32(menu->count);
63 for (uint32_t i = 0; i < menu->count; ++i) 63 for (uint32_t i = 0; i < menu->count; ++i)
64 WriteMenuItem(m, menu->items + i); 64 WriteMenuItem(m, menu->items + i);
65 } 65 }
66 66
67 void FreeMenuItem(const PP_Flash_MenuItem* menu_item) { 67 void FreeMenuItem(const PP_Flash_MenuItem* menu_item) {
68 if (menu_item->name) 68 if (menu_item->name)
69 delete [] menu_item->name; 69 delete [] menu_item->name;
70 if (menu_item->submenu) 70 if (menu_item->submenu)
71 FreeMenu(menu_item->submenu); 71 FreeMenu(menu_item->submenu);
72 } 72 }
73 73
74 void FreeMenu(const PP_Flash_Menu* menu) { 74 void FreeMenu(const PP_Flash_Menu* menu) {
75 if (menu->items) { 75 if (menu->items) {
76 for (uint32_t i = 0; i < menu->count; ++i) 76 for (uint32_t i = 0; i < menu->count; ++i)
77 FreeMenuItem(menu->items + i); 77 FreeMenuItem(menu->items + i);
78 delete [] menu->items; 78 delete [] menu->items;
79 } 79 }
80 delete menu; 80 delete menu;
81 } 81 }
82 82
83 bool ReadMenuItem(int depth, 83 bool ReadMenuItem(int depth,
84 const IPC::Message* m, 84 const base::Pickle* m,
85 base::PickleIterator* iter, 85 base::PickleIterator* iter,
86 PP_Flash_MenuItem* menu_item) { 86 PP_Flash_MenuItem* menu_item) {
87 uint32_t type; 87 uint32_t type;
88 if (!iter->ReadUInt32(&type)) 88 if (!iter->ReadUInt32(&type))
89 return false; 89 return false;
90 if (type > PP_FLASH_MENUITEM_TYPE_SUBMENU) 90 if (type > PP_FLASH_MENUITEM_TYPE_SUBMENU)
91 return false; 91 return false;
92 menu_item->type = static_cast<PP_Flash_MenuItem_Type>(type); 92 menu_item->type = static_cast<PP_Flash_MenuItem_Type>(type);
93 std::string name; 93 std::string name;
94 if (!iter->ReadString(&name)) 94 if (!iter->ReadString(&name))
95 return false; 95 return false;
96 menu_item->name = new char[name.size() + 1]; 96 menu_item->name = new char[name.size() + 1];
97 std::copy(name.begin(), name.end(), menu_item->name); 97 std::copy(name.begin(), name.end(), menu_item->name);
98 menu_item->name[name.size()] = 0; 98 menu_item->name[name.size()] = 0;
99 if (!iter->ReadInt(&menu_item->id)) 99 if (!iter->ReadInt(&menu_item->id))
100 return false; 100 return false;
101 if (!IPC::ReadParam(m, iter, &menu_item->enabled)) 101 if (!IPC::ReadParam(m, iter, &menu_item->enabled))
102 return false; 102 return false;
103 if (!IPC::ReadParam(m, iter, &menu_item->checked)) 103 if (!IPC::ReadParam(m, iter, &menu_item->checked))
104 return false; 104 return false;
105 if (type == PP_FLASH_MENUITEM_TYPE_SUBMENU) { 105 if (type == PP_FLASH_MENUITEM_TYPE_SUBMENU) {
106 menu_item->submenu = ReadMenu(depth, m, iter); 106 menu_item->submenu = ReadMenu(depth, m, iter);
107 if (!menu_item->submenu) 107 if (!menu_item->submenu)
108 return false; 108 return false;
109 } 109 }
110 return true; 110 return true;
111 } 111 }
112 112
113 PP_Flash_Menu* ReadMenu(int depth, 113 PP_Flash_Menu* ReadMenu(int depth,
114 const IPC::Message* m, 114 const base::Pickle* m,
115 base::PickleIterator* iter) { 115 base::PickleIterator* iter) {
116 if (depth > kMaxMenuDepth) 116 if (depth > kMaxMenuDepth)
117 return NULL; 117 return NULL;
118 ++depth; 118 ++depth;
119 119
120 PP_Flash_Menu* menu = new PP_Flash_Menu; 120 PP_Flash_Menu* menu = new PP_Flash_Menu;
121 menu->items = NULL; 121 menu->items = NULL;
122 122
123 if (!iter->ReadUInt32(&menu->count)) { 123 if (!iter->ReadUInt32(&menu->count)) {
124 FreeMenu(menu); 124 FreeMenu(menu);
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 bool SerializedFlashMenu::SetPPMenu(const PP_Flash_Menu* menu) { 159 bool SerializedFlashMenu::SetPPMenu(const PP_Flash_Menu* menu) {
160 DCHECK(!pp_menu_); 160 DCHECK(!pp_menu_);
161 if (!CheckMenu(0, menu)) 161 if (!CheckMenu(0, menu))
162 return false; 162 return false;
163 pp_menu_ = menu; 163 pp_menu_ = menu;
164 own_menu_ = false; 164 own_menu_ = false;
165 return true; 165 return true;
166 } 166 }
167 167
168 168 void SerializedFlashMenu::WriteToMessage(base::Pickle* m) const {
169 void SerializedFlashMenu::WriteToMessage(IPC::Message* m) const {
170 WriteMenu(m, pp_menu_); 169 WriteMenu(m, pp_menu_);
171 } 170 }
172 171
173 bool SerializedFlashMenu::ReadFromMessage(const IPC::Message* m, 172 bool SerializedFlashMenu::ReadFromMessage(const base::Pickle* m,
174 base::PickleIterator* iter) { 173 base::PickleIterator* iter) {
175 DCHECK(!pp_menu_); 174 DCHECK(!pp_menu_);
176 pp_menu_ = ReadMenu(0, m, iter); 175 pp_menu_ = ReadMenu(0, m, iter);
177 if (!pp_menu_) 176 if (!pp_menu_)
178 return false; 177 return false;
179 178
180 own_menu_ = true; 179 own_menu_ = true;
181 return true; 180 return true;
182 } 181 }
183 182
184 } // namespace proxy 183 } // namespace proxy
185 } // namespace ppapi 184 } // namespace ppapi
OLDNEW
« no previous file with comments | « ppapi/proxy/serialized_flash_menu.h ('k') | ppapi/proxy/serialized_var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698