Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: net/quic/test_tools/quic_sent_packet_manager_peer.cc

Issue 1658993002: Deprecate FLAGS_quic_track_single_retransmission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@112982932
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_unacked_packet_map.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_sent_packet_manager_peer.cc
diff --git a/net/quic/test_tools/quic_sent_packet_manager_peer.cc b/net/quic/test_tools/quic_sent_packet_manager_peer.cc
index ec5e6e164bc56bdc94a7f3ce77dc92ec7cdb3e87..b1669774b0b5c224de507fa3fd794cd2f847763a 100644
--- a/net/quic/test_tools/quic_sent_packet_manager_peer.cc
+++ b/net/quic/test_tools/quic_sent_packet_manager_peer.cc
@@ -106,21 +106,15 @@ bool QuicSentPacketManagerPeer::IsRetransmission(
QuicSentPacketManager* sent_packet_manager,
QuicPacketNumber packet_number) {
DCHECK(sent_packet_manager->HasRetransmittableFrames(packet_number));
- if (FLAGS_quic_track_single_retransmission) {
- if (!sent_packet_manager->HasRetransmittableFrames(packet_number)) {
- return false;
- }
- for (auto transmission_info : sent_packet_manager->unacked_packets_) {
- if (transmission_info.retransmission == packet_number) {
- return true;
- }
- }
+ if (!sent_packet_manager->HasRetransmittableFrames(packet_number)) {
return false;
}
- return sent_packet_manager->HasRetransmittableFrames(packet_number) &&
- sent_packet_manager->unacked_packets_.GetTransmissionInfo(
- packet_number)
- .all_transmissions != nullptr;
+ for (auto transmission_info : sent_packet_manager->unacked_packets_) {
+ if (transmission_info.retransmission == packet_number) {
+ return true;
+ }
+ }
+ return false;
}
// static
« no previous file with comments | « net/quic/quic_unacked_packet_map.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698