Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: runtime/vm/atomic_win.h

Issue 1658983004: Change signature of atomic increment/decrement functions to return void. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/atomic_test.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/atomic_win.h
diff --git a/runtime/vm/atomic_win.h b/runtime/vm/atomic_win.h
index 2ade768e2f19e33f86afc840fb2b239500a4a82f..156303593f75d8fbb86a8f8e290e2f797ca03304 100644
--- a/runtime/vm/atomic_win.h
+++ b/runtime/vm/atomic_win.h
@@ -28,16 +28,13 @@ inline uintptr_t AtomicOperations::FetchAndIncrement(uintptr_t* p) {
}
-inline uintptr_t AtomicOperations::FetchAndIncrementBy(intptr_t* p,
- intptr_t value) {
+inline void AtomicOperations::IncrementBy(intptr_t* p, intptr_t value) {
#if defined(HOST_ARCH_X64)
- return static_cast<uintptr_t>(
- InterlockedExchangeAdd64(reinterpret_cast<LONGLONG*>(p),
- static_cast<LONGLONG>(value)));
+ InterlockedExchangeAdd64(reinterpret_cast<LONGLONG*>(p),
+ static_cast<LONGLONG>(value));
#elif defined(HOST_ARCH_IA32)
- return static_cast<uintptr_t>(
- InterlockedExchangeAdd(reinterpret_cast<LONG*>(p),
- static_cast<LONG>(value)));
+ InterlockedExchangeAdd(reinterpret_cast<LONG*>(p),
+ static_cast<LONG>(value));
#else
#error Unsupported host architecture.
#endif
@@ -57,16 +54,13 @@ inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {
}
-inline uintptr_t AtomicOperations::FetchAndDecrementBy(intptr_t* p,
- intptr_t value) {
+inline void AtomicOperations::DecrementBy(intptr_t* p, intptr_t value) {
#if defined(HOST_ARCH_X64)
- return static_cast<uintptr_t>(
- InterlockedExchangeAdd64(reinterpret_cast<LONGLONG*>(p),
- static_cast<LONGLONG>(-value)));
+ InterlockedExchangeAdd64(reinterpret_cast<LONGLONG*>(p),
+ static_cast<LONGLONG>(-value));
#elif defined(HOST_ARCH_IA32)
- return static_cast<uintptr_t>(
- InterlockedExchangeAdd(reinterpret_cast<LONG*>(p),
- static_cast<LONG>(-value)));
+ InterlockedExchangeAdd(reinterpret_cast<LONG*>(p),
+ static_cast<LONG>(-value));
#else
#error Unsupported host architecture.
#endif
« no previous file with comments | « runtime/vm/atomic_test.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698