Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: runtime/vm/atomic_android.h

Issue 1658983004: Change signature of atomic increment/decrement functions to return void. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/atomic.h ('k') | runtime/vm/atomic_linux.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ATOMIC_ANDROID_H_ 5 #ifndef VM_ATOMIC_ANDROID_H_
6 #define VM_ATOMIC_ANDROID_H_ 6 #define VM_ATOMIC_ANDROID_H_
7 7
8 #if !defined VM_ATOMIC_H_ 8 #if !defined VM_ATOMIC_H_
9 #error Do not include atomic_android.h directly. Use atomic.h instead. 9 #error Do not include atomic_android.h directly. Use atomic.h instead.
10 #endif 10 #endif
11 11
12 #if !defined(TARGET_OS_ANDROID) 12 #if !defined(TARGET_OS_ANDROID)
13 #error This file should only be included on Android builds. 13 #error This file should only be included on Android builds.
14 #endif 14 #endif
15 15
16 namespace dart { 16 namespace dart {
17 17
18 18
19 inline uintptr_t AtomicOperations::FetchAndIncrement(uintptr_t* p) { 19 inline uintptr_t AtomicOperations::FetchAndIncrement(uintptr_t* p) {
20 return __sync_fetch_and_add(p, 1); 20 return __sync_fetch_and_add(p, 1);
21 } 21 }
22 22
23 23
24 inline uintptr_t AtomicOperations::FetchAndIncrementBy(intptr_t* p, 24 inline void AtomicOperations::IncrementBy(intptr_t* p, intptr_t value) {
25 intptr_t value) { 25 __sync_fetch_and_add(p, value);
26 return __sync_fetch_and_add(p, value);
27 } 26 }
28 27
29 28
30 inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) { 29 inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {
31 return __sync_fetch_and_sub(p, 1); 30 return __sync_fetch_and_sub(p, 1);
32 } 31 }
33 32
34 33
35 inline uintptr_t AtomicOperations::FetchAndDecrementBy(intptr_t* p, 34 inline void AtomicOperations::DecrementBy(intptr_t* p, intptr_t value) {
36 intptr_t value) { 35 __sync_fetch_and_sub(p, value);
37 return __sync_fetch_and_sub(p, value);
38 } 36 }
39 37
40 38
41 #if !defined(USING_SIMULATOR) 39 #if !defined(USING_SIMULATOR)
42 inline uword AtomicOperations::CompareAndSwapWord(uword* ptr, 40 inline uword AtomicOperations::CompareAndSwapWord(uword* ptr,
43 uword old_value, 41 uword old_value,
44 uword new_value) { 42 uword new_value) {
45 return __sync_val_compare_and_swap(ptr, old_value, new_value); 43 return __sync_val_compare_and_swap(ptr, old_value, new_value);
46 } 44 }
47 45
48 46
49 inline uint32_t AtomicOperations::CompareAndSwapUint32(uint32_t* ptr, 47 inline uint32_t AtomicOperations::CompareAndSwapUint32(uint32_t* ptr,
50 uint32_t old_value, 48 uint32_t old_value,
51 uint32_t new_value) { 49 uint32_t new_value) {
52 return __sync_val_compare_and_swap(ptr, old_value, new_value); 50 return __sync_val_compare_and_swap(ptr, old_value, new_value);
53 } 51 }
54 #endif // !defined(USING_SIMULATOR) 52 #endif // !defined(USING_SIMULATOR)
55 53
56 } // namespace dart 54 } // namespace dart
57 55
58 #endif // VM_ATOMIC_ANDROID_H_ 56 #endif // VM_ATOMIC_ANDROID_H_
OLDNEW
« no previous file with comments | « runtime/vm/atomic.h ('k') | runtime/vm/atomic_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698