Issue 1658983004: Change signature of atomic increment/decrement functions to return void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1658983004: Change signature of atomic increment/decrement functions to return void. (Closed)

Created:
4 years, 10 months ago by siva

Modified:
4 years, 10 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -56 lines)			Patch
M	runtime/vm/atomic.h	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/atomic_android.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/atomic_linux.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/atomic_macos.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/atomic_test.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/atomic_win.h	View	2 chunks	+10 lines, -16 lines	0 comments	Download
M	runtime/vm/pages.cc	View	6 chunks	+12 lines, -14 lines	0 comments	Download

Total messages: 5 (2 generated)

siva

4 years, 10 months ago (2016-02-03 17:15:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf5d8f6efcbac03973613ccac831fc331db45af7 (presubmit successful).