Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: net/quic/quic_connection.cc

Issue 1658923003: Improve loggging to debug invalid acks. No functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113053115
Patch Set: revert clang-format statements Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 43442265e560d8f8decf11503f35227231aeada3..2f4029ea9053b00533c24756c01653eecdf959e2 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -828,7 +828,9 @@ const char* QuicConnection::ValidateAckFrame(const QuicAckFrame& incoming_ack) {
if (!sent_entropy_manager_.IsValidEntropy(incoming_ack.largest_observed,
incoming_ack.missing_packets,
incoming_ack.entropy_hash)) {
- LOG(WARNING) << ENDPOINT << "Peer sent invalid entropy.";
+ LOG(WARNING) << ENDPOINT << "Peer sent invalid entropy."
+ << " largest_observed:" << incoming_ack.largest_observed
+ << " last_received:" << last_header_.packet_number;
return "Invalid entropy";
}
@@ -836,7 +838,8 @@ const char* QuicConnection::ValidateAckFrame(const QuicAckFrame& incoming_ack) {
!incoming_ack.missing_packets.Contains(
incoming_ack.latest_revived_packet)) {
LOG(WARNING) << ENDPOINT
- << "Peer specified revived packet which was not missing.";
+ << "Peer specified revived packet which was not missing."
+ << " revived_packet:" << incoming_ack.latest_revived_packet;
return "Invalid revived packet";
}
return nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698