Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1658913003: SafeBrowsing: Move V4ProtocolManager to components. (Closed)

Created:
4 years, 10 months ago by kcarattini
Modified:
4 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, vakh (use Gerrit instead)
Base URL:
https://chromium.googlesource.com/chromium/src.git@sb-v4-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SafeBrowsing: Move V4ProtocolManager to components. BUG=561867, 543161 Committed: https://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55 Cr-Commit-Position: refs/heads/master@{#373183}

Patch Set 1 #

Patch Set 2 : Fix Build Files #

Patch Set 3 : Rebase #

Patch Set 4 : Add build dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1127 lines) Patch
D chrome/browser/safe_browsing/v4_protocol_manager.h View 1 2 1 chunk +0 lines, -275 lines 0 comments Download
D chrome/browser/safe_browsing/v4_protocol_manager.cc View 1 2 1 chunk +0 lines, -412 lines 0 comments Download
D chrome/browser/safe_browsing/v4_protocol_manager_unittest.cc View 1 2 1 chunk +0 lines, -432 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download
A + components/safe_browsing_db/v4_protocol_manager.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing_db/v4_protocol_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_browsing_db/v4_protocol_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
kcarattini
4 years, 10 months ago (2016-02-02 05:42:49 UTC) #3
vakh (use Gerrit instead)
lgtm
4 years, 10 months ago (2016-02-02 22:58:55 UTC) #5
Nathan Parker
lgtm Great!
4 years, 10 months ago (2016-02-02 23:18:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658913003/40001
4 years, 10 months ago (2016-02-03 04:00:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/16617) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-03 04:05:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658913003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658913003/60001
4 years, 10 months ago (2016-02-03 04:15:33 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-03 05:33:55 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 05:34:55 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55
Cr-Commit-Position: refs/heads/master@{#373183}

Powered by Google App Engine
This is Rietveld 408576698