extensions/browser/guest_view/extension_options/extension_options_guest.cc - Issue 1658913002: Make extensions use a correct same-origin check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 1658913002: Make extensions use a correct same-origin check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't break the tests — we shouldn't have been adding null origins anyway. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/web_request_permissions.cc ('k') | extensions/browser/guest_view/extension_view/extension_view_guest.cc » ('j') | extensions/common/url_pattern_set.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

index 9f3c07af53e48b505f821c24747a125b91e4ca89..a3d8c7c3afd11ee0df1801ebd1c1d6364f1fdd56 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

@@ -231,7 +231,7 @@ void ExtensionOptionsGuest::DidNavigateMainFrame(

ui_zoom::ZoomController::ZOOM_MODE_ISOLATED);

SetGuestZoomLevelToMatchEmbedder();

- if (params.url.GetOrigin() != options_page_.GetOrigin()) {

+ if (!url::IsSameOriginWith(params.url, options_page_)) {

bad_message::ReceivedBadMessage(web_contents()->GetRenderProcessHost(),

bad_message::EOG_BAD_ORIGIN);

}