Enable /analyze in gn builds

build/config/win/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/compiler/compiler.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/win/visual_studio_version.gni")
 
 assert(is_win)
 
 # This is included by reference in the //build/config/compiler config that
 # is applied to all targets. It is here to separate out the logic that is
 # Windows-only.
 config("compiler") {

[brettw, 2016/02/03 18:48:00]

Probably the cleanest way to hook up your analyze config is to just reference it
from this one which is already applied to all targets. To make a sub-config,
just do

  configs = [ ":analyze" ]

in this one.

[brucedawson, 2016/02/06 01:07:30]

I think I had it there initially but then I couldn't remove it.

   if (current_cpu == "x86") {
     asmflags = [
       # When /safeseh is specified, the linker will only produce an image if it
       # can also produce a table of the image's safe exception handlers. This
       # table specifies for the operating system which exception handlers are
       # valid for the image. Note that /SAFESEH isn't accepted on the command
       # line, only /safeseh. This is only accepted by ml.exe, not ml64.exe.
       "/safeseh",
     ]
   }
@@ skipping 48 matching lines @@
     }
   }
 
   if (is_syzyasan) {
     # SyzyAsan needs /PROFILE turned on to produce appropriate pdbs.
     assert(!is_win_fastlink, "/PROFILE and /DEBUG:FASTLINK are incompatible")
     ldflags = [ "/PROFILE" ]
   }
 }
 
+config("win_analyze") {

[brettw, 2016/02/03 18:48:00]

I'd call this just "analyze" since you're already in the "win" directory.

[brucedawson, 2016/02/06 01:07:30]

I just tried that and immediately hit the disadvantage that grepping for it
becomes much harder - 'analyze' is very generic. But, could go either way since
"is_win_analyze" is still easy to search for.

+  if (is_win_analyze) {
+    # When is_win_analyze is specified add the /analyze switch to enable static
+    # analysis. Specifying /analyze:WX- says that /analyze warnings should not
+    # be treated as errors.
+    cflags = [ "/analyze:WX-" ]
+
+    # Also, disable various noisy warnings that have low value.
+    cflags += [
+      "/wd6011",  # Dereferencing NULL pointer
+
+      # C6285 is ~16% of raw warnings and has low value
+      "/wd6285",  # non-zero constant || non-zero constant
+      "/wd6308",  # realloc might return null pointer
+
+      # Possible infinite loop: use of the constant
+      # EXCEPTION_CONTINUE_EXECUTION in the exception-filter
+      "/wd6312",
+
+      "/wd6322",  # Empty _except block
+      "/wd6330",  # 'char' used instead of 'unsigned char' for istype() call
+
+      # C6334 is ~80% of raw warnings and has low value
+      "/wd6334",  # sizeof applied to an expression with an operator
+      "/wd6326",  # Potential comparison of constant with constant
+      "/wd6340",  # Sign mismatch in function parameter
+      "/wd28159",  # Consider using 'GetTickCount64'
+      "/wd28196",  # The precondition is not satisfied
+      "/wd28204",  # Inconsistent SAL annotations
+      "/wd28251",  # Inconsistent SAL annotations
+      "/wd28252",  # Inconsistent SAL annotations
+      "/wd28253",  # Inconsistent SAL annotations
+      "/wd28278",  # Function appears with no prototype in scope
+      "/wd28285",  # syntax error in SAL annotation (in algorithm)
+      "/wd28301",  # Inconsistent SAL annotations
+      "/wd28182",  # Dereferencing NULL pointer
+    ]
+  }
+}
+
 # This is included by reference in the //build/config/compiler:runtime_library
 # config that is applied to all targets. It is here to separate out the logic
 # that is Windows-only. Please see that target for advice on what should go in
 # :runtime_library vs. :compiler.
 config("runtime_library") {
   cflags = []
 
   # Defines that set up the CRT.
   defines = [
     "__STD_C",
     "_CRT_RAND_S",
     "_CRT_SECURE_NO_DEPRECATE",
     "_HAS_EXCEPTIONS=0",
     "_SCL_SECURE_NO_DEPRECATE",
   ]
 
   # Defines that set up the Windows SDK.
   defines += [
     "_ATL_NO_OPENGL",
     "_WINDOWS",
     "CERT_CHAIN_PARA_HAS_EXTRA_FIELDS",
     "NTDDI_VERSION=0x0A000000",
     "PSAPI_VERSION=1",
     "WIN32",
     "_SECURE_ATL",
+  ]
 
+  if (!is_win_analyze) {
     # This is required for ATL to use XP-safe versions of its functions.
-    "_USING_V110_SDK71_",
-  ]
+    # However it is prohibited when using /analyze
+    defines += [ "_USING_V110_SDK71_" ]
+  }
 
   if (is_component_build) {
     # Component mode: dynamic CRT. Since the library is shared, it requires
     # exceptions or will give errors about things not matching, so keep
     # exceptions on.
     if (is_debug) {
       cflags += [ "/MDd" ]
     } else {
       cflags += [ "/MD" ]
     }
@@ skipping 190 matching lines @@
 
 # Internal stuff --------------------------------------------------------------
 
 # Config used by the MIDL template to disable warnings.
 config("midl_warnings") {
   if (is_clang) {
     # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
     cflags = [ "-Wno-extra-tokens" ]
   }
 }