Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 1658823002: Remove deferred clear from SkGpuDevice (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove deferred clear from SkGpuDevice Add combining to GrClearBatch Fix issue with state tracking in GrGLGpu::createTestingOnlyBackendTexture Add tests for clearing GPU SkSurfaces and add tests for GrDrawContext::clear(). Add comment that SkCanvas::flush will resolve the RT in the GPU case. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658823002 Committed: https://skia.googlesource.com/skia/+/e63ffef6248bd103b5f7827f1e4bc75e47ca9e20

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : whitespace #

Patch Set 5 : remove debug hack #

Patch Set 6 : Fix release build warning. #

Patch Set 7 : Fix ptr->bool warning on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -40 lines) Patch
M gm/imagefromyuvtextures.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 9 chunks +3 lines, -22 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 1 1 chunk +13 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 5 chunks +4 lines, -5 lines 0 comments Download
A tests/ClearTest.cpp View 1 2 3 4 5 6 1 chunk +236 lines, -0 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 3 chunks +84 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
bsalomon
4 years, 10 months ago (2016-02-04 16:42:20 UTC) #5
robertphillips
lgtm
4 years, 10 months ago (2016-02-04 17:08:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658823002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658823002/80001
4 years, 10 months ago (2016-02-04 17:09:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/5881)
4 years, 10 months ago (2016-02-04 17:11:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658823002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658823002/100001
4 years, 10 months ago (2016-02-05 13:47:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, no build URL) Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on ...
4 years, 10 months ago (2016-02-05 13:47:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658823002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658823002/120001
4 years, 10 months ago (2016-02-05 14:46:01 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 15:17:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/e63ffef6248bd103b5f7827f1e4bc75e47ca9e20

Powered by Google App Engine
This is Rietveld 408576698