chrome/browser/extensions/extension_tabs_apitest.cc - Issue 1658793002: Update chrome for new prefs location.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 1658793002: Update chrome for new prefs location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_sync_service_factory.cc ('k') | chrome/browser/extensions/extension_ui_util.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6	6

7 #include "base/prefs/pref_service.h"

8 #include "build/build_config.h"	7 #include "build/build_config.h"

9 #include "chrome/browser/prefs/incognito_mode_prefs.h"	8 #include "chrome/browser/prefs/incognito_mode_prefs.h"

10 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

11 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

12 #include "chrome/browser/ui/browser_window.h"	11 #include "chrome/browser/ui/browser_window.h"

13 #include "chrome/common/chrome_switches.h"	12 #include "chrome/common/chrome_switches.h"

14 #include "chrome/common/pref_names.h"	13 #include "chrome/common/pref_names.h"

15 #include "chrome/common/url_constants.h"	14 #include "chrome/common/url_constants.h"

	15 #include "components/prefs/pref_service.h"

16 #include "net/dns/mock_host_resolver.h"	16 #include "net/dns/mock_host_resolver.h"

17	17

18 #if defined(OS_WIN)	18 #if defined(OS_WIN)

19 #include "ui/aura/window.h"	19 #include "ui/aura/window.h"

20 #include "ui/aura/window_tree_host.h"	20 #include "ui/aura/window_tree_host.h"

21 #endif	21 #endif

22	22

23 #if defined(USE_AURA) \|\| defined(OS_MACOSX)	23 #if defined(USE_AURA) \|\| defined(OS_MACOSX)

24 // Maximizing/fullscreen popup window doesn't work on aura's managed mode.	24 // Maximizing/fullscreen popup window doesn't work on aura's managed mode.

25 // See bug crbug.com/116305.	25 // See bug crbug.com/116305.

(...skipping 239 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
265 << message_;	265 << message_;

266 }	266 }

267 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {	267 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {

268 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))	268 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))

269 << message_;	269 << message_;

270 }	270 }

271	271

272 // Adding a new test? Awesome. But API tests are the old hotness. The new	272 // Adding a new test? Awesome. But API tests are the old hotness. The new

273 // hotness is extension_function_test_utils. See tabs_test.cc for an example.	273 // hotness is extension_function_test_utils. See tabs_test.cc for an example.

274 // We are trying to phase out many uses of API tests as they tend to be flaky.	274 // We are trying to phase out many uses of API tests as they tend to be flaky.

OLD	NEW