Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1658783003: - Add missing transition in Dart_ThrowException and Dart_ReThrowException (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review-comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 6567b579befc5bd7ed9c1cffb2ea317dcd937f14..89064e08604eec57560bd5ae0dfd10b834a64d19 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -856,6 +856,7 @@ DART_EXPORT Dart_Handle Dart_PropagateError(Dart_Handle handle) {
return Api::NewError("No Dart frames on stack, cannot propagate error.");
}
+ TransitionNativeToVM transition(thread);
// Unwind all the API scopes till the exit frame before propagating.
const Error* error;
{
@@ -1568,7 +1569,7 @@ DART_EXPORT Dart_Handle Dart_HandleMessage() {
CHECK_API_SCOPE(T);
CHECK_CALLBACK_STATE(T);
API_TIMELINE_BEGIN_END;
- TransitionNativeToVM trainsition(T);
+ TransitionNativeToVM transition(T);
if (I->message_handler()->HandleNextMessage() != MessageHandler::kOK) {
Dart_Handle error = Api::NewHandle(T, I->object_store()->sticky_error());
I->object_store()->clear_sticky_error();
@@ -1584,7 +1585,7 @@ DART_EXPORT bool Dart_HandleServiceMessages() {
CHECK_API_SCOPE(T);
CHECK_CALLBACK_STATE(T);
API_TIMELINE_DURATION;
- TransitionNativeToVM trainsition(T);
+ TransitionNativeToVM transition(T);
ASSERT(I->GetAndClearResumeRequest() == false);
MessageHandler::MessageStatus status =
I->message_handler()->HandleOOBMessages();
@@ -4421,6 +4422,7 @@ DART_EXPORT Dart_Handle Dart_ThrowException(Dart_Handle exception) {
return Api::NewError("No Dart frames on stack, cannot throw exception");
}
+ TransitionNativeToVM transition(thread);
// Unwind all the API scopes till the exit frame before throwing an
// exception.
const Instance* saved_exception;
@@ -4459,6 +4461,7 @@ DART_EXPORT Dart_Handle Dart_ReThrowException(Dart_Handle exception,
return Api::NewError("No Dart frames on stack, cannot throw exception");
}
+ TransitionNativeToVM transition(thread);
// Unwind all the API scopes till the exit frame before throwing an
// exception.
const Instance* saved_exception;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698