Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1658783003: - Add missing transition in Dart_ThrowException and Dart_ReThrowException (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Add missing transition in Dart_ThrowException and Dart_ReThrowException - Fixed some typo in other places R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/36515b8bbb9763698b446fc9eab70401a1335951

Patch Set 1 #

Total comments: 1

Patch Set 2 : address-code-review-comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 5 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years, 10 months ago (2016-02-01 23:23:51 UTC) #2
rmacnak
https://codereview.chromium.org/1658783003/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1658783003/diff/1/runtime/vm/dart_api_impl.cc#newcode841 runtime/vm/dart_api_impl.cc:841: DART_EXPORT Dart_Handle Dart_PropagateError(Dart_Handle handle) { Here too.
4 years, 10 months ago (2016-02-01 23:38:00 UTC) #3
siva
4 years, 10 months ago (2016-02-01 23:43:33 UTC) #4
rmacnak
lgtm
4 years, 10 months ago (2016-02-01 23:45:29 UTC) #5
siva
4 years, 10 months ago (2016-02-02 00:02:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
36515b8bbb9763698b446fc9eab70401a1335951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698