Issue 1658763002: mojom.dart: Allow package name != directory name

Issue 1658763002: mojom.dart: Allow package name != directory name (Closed)

Created:
4 years, 10 months ago by zra

Modified:
4 years, 10 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, alhaad

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

mojom.dart: Allow package name != directory name fixes #637 R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/00e94a86cd496abeb701b9f68447374584c67714

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -44 lines)			Patch
M	mojo/dart/packages/mojom/lib/src/generate.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/dart/packages/mojom/lib/src/mojom_finder.dart	View	3 chunks	+37 lines, -6 lines	0 comments	Download
M	mojo/dart/packages/mojom/lib/src/utils.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/dart/packages/mojom/pubspec.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/dart/packages/mojom/test/generate_test.dart	View	5 chunks	+71 lines, -38 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

4 years, 10 months ago (2016-02-01 22:03:27 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
00e94a86cd496abeb701b9f68447374584c67714 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages