Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 165873004: Make Linux GN build's cflags match GYP's (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Make Linux GN build's cflags match GYP's This is for the base shared library target on desktop Linux. The remaining difference on Linux is that GYP's base build specifies -Wno-write-strings on Linux. This dates back to the first GYP file. I don't know why we would specify this for only base, and it seems not to trigger any warning without this flag, so I didn't add it. This changes the pkg-config invocation from --libs to --libs-only-L and --libs-only-l. The output seems slightly different (--libs was producing an extra --export-dynamic for gmodule-2.0 that aren't present when invoking the other way, which is what the GYP build does). R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252409

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M build/config/compiler/BUILD.gn View 1 3 chunks +32 lines, -7 lines 0 comments Download
M build/config/linux/pkg-config.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 10 months ago (2014-02-19 22:00:06 UTC) #1
Nico
lgtm Maybe remove -Wno-write-strings from gyp too?
6 years, 10 months ago (2014-02-19 22:03:28 UTC) #2
brettw
6 years, 10 months ago (2014-02-20 23:02:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r252409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698