Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1658723005: Resynthesize static method references. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move the 'no staticType check' comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 1 chunk +11 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 2 chunks +43 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 10 months ago (2016-02-01 20:40:17 UTC) #1
Paul Berry
https://codereview.chromium.org/1658723005/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (left): https://codereview.chromium.org/1658723005/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart#oldcode239 pkg/analyzer/test/src/summary/resynthesize_test.dart:239: compareTypes(r.staticType, o.staticType, desc); Why is it ok to delete ...
4 years, 10 months ago (2016-02-01 20:48:47 UTC) #2
scheglov
https://codereview.chromium.org/1658723005/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (left): https://codereview.chromium.org/1658723005/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart#oldcode239 pkg/analyzer/test/src/summary/resynthesize_test.dart:239: compareTypes(r.staticType, o.staticType, desc); On 2016/02/01 20:48:47, Paul Berry wrote: ...
4 years, 10 months ago (2016-02-01 20:52:45 UTC) #3
Paul Berry
lgtm
4 years, 10 months ago (2016-02-01 20:56:59 UTC) #4
scheglov
4 years, 10 months ago (2016-02-01 20:58:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
eff97b738e4b7aa61d63df20dd9bb1eee04bb0d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698