Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1658663002: Move ResolverProvider to analyzer so that it can be shared (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move ResolverProvider to analyzer so that it can be shared R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5b95009a6be4546eeabd9a0c394d018a03220769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -42 lines) Patch
D pkg/analysis_server/lib/plugin/analysis/resolver_provider.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/starter.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/lib/plugin/resolver_provider.dart View 2 chunks +1 line, -3 lines 0 comments Download
D pkg/analyzer_cli/lib/plugin/analysis/resolver_provider.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/starter.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-01 16:05:28 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-01 16:07:05 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-01 16:12:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b95009a6be4546eeabd9a0c394d018a03220769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698