Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1658643002: LayoutBox cannot be non-atomic inline. (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutBox cannot be non-atomic inline. Don't account for such a situation. Instead, just assert that it doesn't happen. Committed: https://crrev.com/907140689d87d0ba3a34cef12696bfdc28db292f Cr-Commit-Position: refs/heads/master@{#372823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-01 19:46:26 UTC) #3
pilgrim_google
On 2016/02/01 at 19:46:26, mstensho wrote: > Not a reviewer. Adding eae.
4 years, 10 months ago (2016-02-01 22:23:54 UTC) #4
pilgrim_google
On 2016/02/01 at 22:23:54, pilgrim_google wrote: > On 2016/02/01 at 19:46:26, mstensho wrote: > > ...
4 years, 10 months ago (2016-02-01 22:24:51 UTC) #6
leviw_travelin_and_unemployed
Yurp. LGTM
4 years, 10 months ago (2016-02-01 23:33:47 UTC) #8
eae
rs-LGTM
4 years, 10 months ago (2016-02-01 23:37:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658643002/1
4 years, 10 months ago (2016-02-01 23:42:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 23:53:10 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 23:54:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/907140689d87d0ba3a34cef12696bfdc28db292f
Cr-Commit-Position: refs/heads/master@{#372823}

Powered by Google App Engine
This is Rietveld 408576698