Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4295)

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 165853002: [OSX, OmniTheatre] URL hiding for Origin Chip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index 023442911e33bb7a21c26e776514320dee668f48..d1580aa7f1b40f888066d95fe846ac415c461470 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -399,7 +399,8 @@ class NotificationBridge
- (void)focusLocationBar:(BOOL)selectAll {
if (locationBarView_.get()) {
- if (chrome::ShouldDisplayOriginChip() && selectAll) {
+ if (selectAll &&
+ locationBarView_->GetToolbarModel()->WouldOmitURLDueToOriginChip()) {
// select_all is true when it's expected that the user may want to copy
// the URL to the clipboard. If the origin chip is being displayed (and
// thus the URL is not being shown in the Omnibox) show it now to support

Powered by Google App Engine
This is Rietveld 408576698