Issue 1658393003: Make a SerializedPacket a member variable of QuicPacketCreator to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1658393003: Make a SerializedPacket a member variable of QuicPacketCreator to (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)

Modified:
4 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett

Base URL:
https://chromium.googlesource.com/chromium/src.git@113076102

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make a SerializedPacket a member variable of QuicPacketCreator to replace the corresponding fields. No functional change, not flag protected. Merge internal change: 113108401 R=rch@chromium.org

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+171 lines, -179 lines)			Patch
M	net/quic/quic_packet_creator.h	View	8 chunks	+28 lines, -44 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	27 chunks	+127 lines, -122 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.cc	View	5 chunks	+13 lines, -10 lines	0 comments	Download

Depends on Patchset:

Issue 1667513002 Patch 1

Dependent Patchsets:

Issue 1660143003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages