runtime/third_party/double-conversion/src/bignum.cc - Issue 1658343002: Update double-conversion and reapply NO_LINTs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/third_party/double-conversion/src/bignum.cc

Issue 1658343002: Update double-conversion and reapply NO_LINTs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/third_party/double-conversion/src/bignum.cc

diff --git a/runtime/third_party/double-conversion/src/bignum.cc b/runtime/third_party/double-conversion/src/bignum.cc

index 2743d67e8d922aaab3283a586dcd7c97ad7a78a9..8892de8f2a3a70102aa8f5b724db8f664992ee28 100644

--- a/runtime/third_party/double-conversion/src/bignum.cc

+++ b/runtime/third_party/double-conversion/src/bignum.cc

@@ -104,7 +104,7 @@ void Bignum::AssignDecimalString(Vector<const char> value) {

const int kMaxUint64DecimalDigits = 19;

Zero();

int length = value.length();

- int pos = 0;

+ unsigned int pos = 0;

// Let's just say that each digit needs 4 bits.

while (length >= kMaxUint64DecimalDigits) {

uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits);