Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1658343002: Update double-conversion and reapply NO_LINTs. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update double-conversion and reapply NO_LINTs. Fixes a -Werror=strict-overflow in gcc 5.2.1. https://github.com/google/double-conversion/commit/56a04575a474b929a4aa4fb72d83d46c8a93f294 BUG=http://dartbug.com/25630 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/e8a32926209564893ecf607b0c8e3cdf210c05c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -88 lines) Patch
M runtime/third_party/double-conversion/src/bignum.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/third_party/double-conversion/src/bignum.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/third_party/double-conversion/src/cached-powers.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/third_party/double-conversion/src/diy-fp.h View 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.h View 3 chunks +20 lines, -13 lines 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.cc View 17 chunks +123 lines, -52 lines 0 comments Download
M runtime/third_party/double-conversion/src/utils.h View 5 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 10 months ago (2016-02-02 22:00:11 UTC) #3
floitsch
LGTM.
4 years, 10 months ago (2016-02-02 22:12:05 UTC) #4
rmacnak
4 years, 10 months ago (2016-02-02 22:30:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8a32926209564893ecf607b0c8e3cdf210c05c7.

Powered by Google App Engine
This is Rietveld 408576698