Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1658303002: Create abstract interface for media::Pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate PipelineImpl. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index e56b4bb17a0bc88f2c75e690abca676b8fcddeb9..f4b61ed1407c8dd4957adb24e2253c4aa6c31db2 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -1216,7 +1216,8 @@ void WebMediaPlayerImpl::Resume() {
chunk_demuxer_->StartWaitingForSeek(seek_time_);
resuming_ = true;
- pipeline_.Resume(CreateRenderer(), seek_time_,
+ scoped_ptr<Renderer> renderer = CreateRenderer();
+ pipeline_.Resume(&renderer, seek_time_,
BIND_TO_RENDER_LOOP1(&WebMediaPlayerImpl::OnPipelineSeeked,
time_changed));
}
@@ -1347,8 +1348,9 @@ void WebMediaPlayerImpl::StartPipeline() {
seeking_ = true;
// TODO(sandersd): On Android, defer Start() if the tab is not visible.
+ scoped_ptr<Renderer> renderer = CreateRenderer();
pipeline_.Start(
- demuxer_.get(), CreateRenderer(),
+ demuxer_.get(), &renderer,
BIND_TO_RENDER_LOOP(&WebMediaPlayerImpl::OnPipelineEnded),
BIND_TO_RENDER_LOOP(&WebMediaPlayerImpl::OnPipelineError),
BIND_TO_RENDER_LOOP1(&WebMediaPlayerImpl::OnPipelineSeeked, false),

Powered by Google App Engine
This is Rietveld 408576698