chrome/renderer/validation_message_agent.h - Issue 16583005: Some improvement of validation message bubble UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/validation_message_agent.h

Issue 16583005: Some improvement of validation message bubble UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/validation_message_agent.h

diff --git a/chrome/renderer/validation_message_agent.h b/chrome/renderer/validation_message_agent.h

index 7113b074a4a3ba04f0c068e14e82df3f8c98bc27..7119d174fd329932ceba6636f9dd29dfe625ce6d 100644

--- a/chrome/renderer/validation_message_agent.h

+++ b/chrome/renderer/validation_message_agent.h

@@ -22,11 +22,13 @@ class ValidationMessageAgent : public content::RenderViewObserver,

private:

// WebValidationMessageClient functions:

- virtual void showValidationMessage(const WebKit::WebRect& anchor_in_screen,

+ virtual void showValidationMessage(const WebKit::WebRect& anchor_in_root_view,

const WebKit::WebString& main_text,

const WebKit::WebString& sub_text,

WebKit::WebTextDirection hint) OVERRIDE;

virtual void hideValidationMessage() OVERRIDE;

+ virtual void moveValidationMessage(

+ const WebKit::WebRect& anchor_in_root_view);

DISALLOW_COPY_AND_ASSIGN(ValidationMessageAgent);

};