Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/gtk/bubble/bubble_gtk.cc

Issue 16583005: Some improvement of validation message bubble UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: renaming Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm ('K') | « chrome/browser/ui/gtk/bubble/bubble_gtk.h ('k') | chrome/browser/ui/gtk/validation_message_bubble_gtk.cc » ('j') | chrome/browser/ui/views/validation_message_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/bubble/bubble_gtk.cc
diff --git a/chrome/browser/ui/gtk/bubble/bubble_gtk.cc b/chrome/browser/ui/gtk/bubble/bubble_gtk.cc
index eb9a040b0d9bcb2a6e0a48bed92865664c54d206..92ef590d12941aedac96f684a04a6900aeadd481 100644
--- a/chrome/browser/ui/gtk/bubble/bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/bubble/bubble_gtk.cc
@@ -557,6 +557,13 @@ void BubbleGtk::Close() {
// |this| has been deleted, see OnDestroy.
}
+void BubbleGtk::SetPositionRelativeToAnchor(const gfx::Rect* rect) {
+ rect_ = rect ? *rect : gtk_util::WidgetBounds(anchor_widget_);
+ if (!UpdateFrameStyle(false)) {
Evan Stade 2013/06/10 19:30:02 nit: no curlies
tkent 2013/06/11 07:02:43 Done.
+ MoveWindow();
+ }
+}
+
void BubbleGtk::GrabPointerAndKeyboard() {
GdkWindow* gdk_window = gtk_widget_get_window(window_);
« chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm ('K') | « chrome/browser/ui/gtk/bubble/bubble_gtk.h ('k') | chrome/browser/ui/gtk/validation_message_bubble_gtk.cc » ('j') | chrome/browser/ui/views/validation_message_bubble_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698