 Chromium Code Reviews
 Chromium Code Reviews Issue 16583005:
  Some improvement of validation message bubble UI.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 16583005:
  Some improvement of validation message bubble UI.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/ui/validation_message_bubble.h | 
| diff --git a/chrome/browser/ui/validation_message_bubble.h b/chrome/browser/ui/validation_message_bubble.h | 
| index 6192bea775ccabe666695bb3be3266a3813a6028..6685917ba06762cf5ad23dc8e33073e4ad659e05 100644 | 
| --- a/chrome/browser/ui/validation_message_bubble.h | 
| +++ b/chrome/browser/ui/validation_message_bubble.h | 
| @@ -24,12 +24,17 @@ class ValidationMessageBubble { | 
| // should not change focus state. | 
| static scoped_ptr<ValidationMessageBubble> CreateAndShow( | 
| content::RenderWidgetHost* widget_host, | 
| - const gfx::Rect& anchor_in_screen, | 
| + const gfx::Rect& anchor_in_root_view, | 
| const string16& main_text, | 
| const string16& sub_text); | 
| // Close the window and destruct the object. | 
| virtual ~ValidationMessageBubble() {} | 
| + | 
| + // Move the window on the specified anchor. | 
| 
Nico
2013/06/07 16:35:31
s/on/to/
 
Nico
2013/06/07 16:35:31
Say which coordinate system the anchor is in (rela
 
sky
2013/06/07 17:52:52
This name is also confusing. Maybe something like
 
tkent
2013/06/10 06:15:37
ok, add comments and renamed it to SetPositionRela
 | 
| + virtual void MoveOnAnchor( | 
| + content::RenderWidgetHost* widget_host, | 
| + const gfx::Rect& anchor_in_root_view) = 0; | 
| }; | 
| } // namespace chrome |