Some improvement of validation message bubble UI.

chrome/browser/ui/gtk/validation_message_bubble_gtk.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/validation_message_bubble.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/gtk/bubble/bubble_gtk.h"
 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
@@ skipping 16 matching lines @@
 
 // A GTK implementation of ValidationMessageBubble.
 class ValidationMessageBubbleGtk : public chrome::ValidationMessageBubble,
                                    public BubbleDelegateGtk {
  public:
   ValidationMessageBubbleGtk(content::RenderWidgetHost* widget_host,
                              const gfx::Rect& anchor_in_screen,
                              const string16& main_text,
                              const string16& sub_text);
   virtual ~ValidationMessageBubbleGtk();
+  virtual void SetPositionRelativeToAnchor(
+      content::RenderWidgetHost* widget_host,
+      const gfx::Rect& anchor_in_root_view) OVERRIDE;
 
   // BubbleDelegateGtk override:
   virtual void BubbleClosing(BubbleGtk*, bool) OVERRIDE;
 
  private:
   static GtkWidget* ConstructContent(const string16& main_text,
                                      const string16& sub_text);
 
   BubbleGtk* bubble_;
 };
 
 ValidationMessageBubbleGtk::ValidationMessageBubbleGtk(
     content::RenderWidgetHost* widget_host,
-    const gfx::Rect& anchor_in_screen,
+    const gfx::Rect& anchor_in_root_view,
     const string16& main_text,
     const string16& sub_text)
     : bubble_(NULL) {
   if (!widget_host->IsRenderView())
     return;
-  gfx::Rect bounds_in_screen = widget_host->GetView()->GetViewBounds();
-  gfx::Rect anchor = anchor_in_screen;
-  anchor.Offset(-bounds_in_screen.x(), -bounds_in_screen.y());
-
   Profile* profile = Profile::FromBrowserContext(
       content::WebContents::FromRenderViewHost(
           content::RenderViewHost::From(widget_host))->GetBrowserContext());
   bubble_ = BubbleGtk::Show(widget_host->GetView()->GetNativeView(),
-                            &anchor,
+                            &anchor_in_root_view,
                             ConstructContent(main_text, sub_text),
                             BubbleGtk::ANCHOR_TOP_LEFT,
                             BubbleGtk::POPUP_WINDOW,
                             GtkThemeService::GetFrom(profile),
                             this);
 }
 
 ValidationMessageBubbleGtk::~ValidationMessageBubbleGtk() {
   if (bubble_)
     bubble_->Close();
 }
 
+void ValidationMessageBubbleGtk::SetPositionRelativeToAnchor(
+    content::RenderWidgetHost* widget_host,
+    const gfx::Rect& anchor_in_root_view) {
+  if (bubble_)
+    bubble_->SetPositionRelativeToAnchor(&anchor_in_root_view);
+}
+
 void ValidationMessageBubbleGtk::BubbleClosing(BubbleGtk*, bool) {
   bubble_ = NULL;
 }
 
 // static
 GtkWidget* ValidationMessageBubbleGtk::ConstructContent(
       const string16& main_text, const string16& sub_text) {
   GtkWidget* icon = gtk_image_new();
   gtk_misc_set_alignment(GTK_MISC(icon), 0.5, 0);
   gtk_misc_set_padding(GTK_MISC(icon), kPadding, kPadding);
@@ skipping 30 matching lines @@
   gtk_container_add(GTK_CONTAINER(content), icon_text_box);
   return content;
 }
 
 }  // namespace
 
 namespace chrome {
 
 scoped_ptr<ValidationMessageBubble> ValidationMessageBubble::CreateAndShow(
     content::RenderWidgetHost* widget_host,
-    const gfx::Rect& anchor_in_screen,
+    const gfx::Rect& anchor_in_root_view,
     const string16& main_text,
     const string16& sub_text) {
   return scoped_ptr<ValidationMessageBubble>(new ValidationMessageBubbleGtk(
-      widget_host, anchor_in_screen, main_text, sub_text)).Pass();
+      widget_host, anchor_in_root_view, main_text, sub_text)).Pass();
 }
 
 }  // namespace chrome