Some improvement of validation message bubble UI.

chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/validation_message_bubble.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "grit/theme_resources.h"
@@ skipping 116 matching lines @@
   return contentView;
 }
 
 
 @end  // implementation ValidationMessageBubbleCocoa
 
 // ----------------------------------------------------------------
 
 namespace {
 
+NSPoint GetAnchorPoint(content::RenderWidgetHost* widget_host,

[Nico, 2013/06/07 16:35:31]

Can you add a comment above this function, explaining what it does? "// Converts
anchor_in_root_view in rwhv coordinates to cocoa screen coordinates" I guess?

[tkent, 2013/06/10 06:15:37]

Done.

+                       const gfx::Rect& anchor_in_root_view) {
+  content::RenderWidgetHostView* view = widget_host->GetView();
+  gfx::Rect anchor_in_screen = anchor_in_root_view
+      + view->GetViewBounds().origin().OffsetFromOrigin();
+  NSWindow* parent_window = [view->GetNativeView() window];
+  return NSMakePoint(anchor_in_screen.x() + anchor_in_screen.width() / 2,
+                     NSHeight([[parent_window screen] frame])
+                         - (anchor_in_screen.y() + anchor_in_screen.height()));

[Nico, 2013/06/07 16:35:31]

If this function does what I think it does, the more usual way to do this is

  NSView* view = widget_host->GetView()->GetNativeView();
  NSRect cocoaRect = [view flipRectToNSRect:anchor_in_root_view];
  NSRect windowRect = [view convertRect:cocoaRect toView:nil];
  NSRect screenRect = [[view window] convertBaseToScreen:windowPoint];
  return screenRect.origin;
  

[tkent, 2013/06/10 06:15:37]

Done.

+}
+
 class ValidationMessageBubbleCocoa : public chrome::ValidationMessageBubble {
  public:
   ValidationMessageBubbleCocoa(content::RenderWidgetHost* widget_host,
-                               const gfx::Rect& anchor_in_screen,
+                               const gfx::Rect& anchor_in_root_view,
                                const string16& main_text,
                                const string16& sub_text) {
-    NSWindow* parent_window = [widget_host->GetView()->GetNativeView() window];
-    NSPoint anchor_point = NSMakePoint(
-        anchor_in_screen.x() + anchor_in_screen.width() / 2,
-        NSHeight([[parent_window screen] frame])
-            - (anchor_in_screen.y() + anchor_in_screen.height()));
     controller_.reset([[[ValidationMessageBubbleController alloc]
-                        init:parent_window
-                  anchoredAt:anchor_point
+                        init:[widget_host->GetView()->GetNativeView() window]
+                  anchoredAt:GetAnchorPoint(widget_host, anchor_in_root_view)
                     mainText:main_text
                      subText:sub_text] retain]);
   }
 
   virtual ~ValidationMessageBubbleCocoa() {
     [controller_.get() close];
   }
 
+  virtual void MoveOnAnchor(content::RenderWidgetHost* widget_host,

[Nico, 2013/06/07 16:35:31]

(same nit as in the android file here too, and in all the other places where
it's overridden)

[tkent, 2013/06/10 06:15:37]

Done.

+                            const gfx::Rect& anchor_in_root_view) OVERRIDE {
+    [controller_.get()
+        setAnchorPoint:GetAnchorPoint(widget_host, anchor_in_root_view)];
+  }
+
  private:
   scoped_nsobject<ValidationMessageBubbleController> controller_;
 };
 
 }
 
 // ----------------------------------------------------------------
 
 namespace chrome {
 
 scoped_ptr<ValidationMessageBubble> ValidationMessageBubble::CreateAndShow(
     content::RenderWidgetHost* widget_host,
-    const gfx::Rect& anchor_in_screen,
+    const gfx::Rect& anchor_in_root_view,
     const string16& main_text,
     const string16& sub_text) {
   return scoped_ptr<ValidationMessageBubble>(new ValidationMessageBubbleCocoa(
-      widget_host, anchor_in_screen, main_text, sub_text)).Pass();
+      widget_host, anchor_in_root_view, main_text, sub_text)).Pass();
 }
 
 }