Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/ui/android/validation_message_bubble_android.h

Issue 16583005: Some improvement of validation message bubble UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_ANDROID_VALIDATION_MESSAGE_BUBBLE_ANDROID_H_ 5 #ifndef CHROME_BROWSER_UI_ANDROID_VALIDATION_MESSAGE_BUBBLE_ANDROID_H_
6 #define CHROME_BROWSER_UI_ANDROID_VALIDATION_MESSAGE_BUBBLE_ANDROID_H_ 6 #define CHROME_BROWSER_UI_ANDROID_VALIDATION_MESSAGE_BUBBLE_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // An implementation of ValidationMessageBubble for Android. This class is a 22 // An implementation of ValidationMessageBubble for Android. This class is a
23 // bridge to a Java implementation. 23 // bridge to a Java implementation.
24 class ValidationMessageBubbleAndroid : public chrome::ValidationMessageBubble { 24 class ValidationMessageBubbleAndroid : public chrome::ValidationMessageBubble {
25 public: 25 public:
26 ValidationMessageBubbleAndroid(content::RenderWidgetHost* widget_host, 26 ValidationMessageBubbleAndroid(content::RenderWidgetHost* widget_host,
27 const gfx::Rect& anchor_in_screen, 27 const gfx::Rect& anchor_in_screen,
28 const string16& main_text, 28 const string16& main_text,
29 const string16& sub_text); 29 const string16& sub_text);
30 virtual ~ValidationMessageBubbleAndroid(); 30 virtual ~ValidationMessageBubbleAndroid();
31 virtual void MoveOnAnchor(content::RenderWidgetHost* widget_host, 31 virtual void MoveOnAnchor(content::RenderWidgetHost* widget_host,
Nico 2013/06/07 16:35:31 nit: It's not clear to me what "MoveOnAnchor" shou
tkent 2013/06/10 06:15:37 Done.
32 const gfx::Rect& anchor_in_screen); 32 const gfx::Rect& anchor_in_screen) OVERRIDE;
33 33
34 static bool Register(JNIEnv* env); 34 static bool Register(JNIEnv* env);
35 35
36 private: 36 private:
37 base::android::ScopedJavaGlobalRef<jobject> java_validation_message_bubble_; 37 base::android::ScopedJavaGlobalRef<jobject> java_validation_message_bubble_;
38 }; 38 };
39 39
40 #endif // CHROME_BROWSER_UI_ANDROID_VALIDATION_MESSAGE_BUBBLE_ANDROID_H_ 40 #endif // CHROME_BROWSER_UI_ANDROID_VALIDATION_MESSAGE_BUBBLE_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698