Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1658233002: Revert of Fix race in UseNewEDK(). (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix race in UseNewEDK(). (patchset #1 id:1 of https://codereview.chromium.org/1646223002/ ) Reason for revert: Broke some tests in official builds, see http://crbug.com/583040 (comment 9 has repro steps) Original issue's description: > Fix race in UseNewEDK(). > > BUG=539315 > > Committed: https://crrev.com/189f17c6d5206a9c0ef6af99f598079f637579af > Cr-Commit-Position: refs/heads/master@{#372501} TBR=jam@chromium.org,amistry@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=539315 Committed: https://crrev.com/fc929dbfc02425dc56c6b4cf3948434feffb578b Cr-Commit-Position: refs/heads/master@{#372978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/entrypoints.cc View 2 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Nico
Created Revert of Fix race in UseNewEDK().
4 years, 10 months ago (2016-02-02 16:27:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658233002/1
4 years, 10 months ago (2016-02-02 16:28:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658233002/1
4 years, 10 months ago (2016-02-02 16:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658233002/1
4 years, 10 months ago (2016-02-02 17:08:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658233002/1
4 years, 10 months ago (2016-02-02 17:37:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 17:44:01 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 17:46:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc929dbfc02425dc56c6b4cf3948434feffb578b
Cr-Commit-Position: refs/heads/master@{#372978}

Powered by Google App Engine
This is Rietveld 408576698