Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/command_args.cc

Issue 165823003: GN: Change gen command syntax, support relative dirs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change in build file writing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/BUILD.gn ('K') | « base/files/file_path.h ('k') | tools/gn/command_gen.cc » ('j') | tools/gn/filesystem_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_args.cc
diff --git a/tools/gn/command_args.cc b/tools/gn/command_args.cc
index dd28c11839efdb7a3101892fcf834f3857fe0041..dd4e3c4c8644611084027c9d7d2f85ad9598a44c 100644
--- a/tools/gn/command_args.cc
+++ b/tools/gn/command_args.cc
@@ -120,7 +120,9 @@ extern const char kArgs_Help[] =
int RunArgs(const std::vector<std::string>& args) {
Setup* setup = new Setup;
setup->set_check_for_bad_items(false);
- if (!setup->DoSetup() || !setup->Run())
+ // TODO(brettw) bug 343726: Use a temporary directory instead of this
+ // default one to avoid messing up any build that's in there.
+ if (!setup->DoSetup("//out/Default/") || !setup->Run())
return 1;
Scope::KeyValueMap build_args;
« base/BUILD.gn ('K') | « base/files/file_path.h ('k') | tools/gn/command_gen.cc » ('j') | tools/gn/filesystem_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698