Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 1658223002: DEPS for gn, used by 'gclient runhooks' to sync gn in buildtools/. (Closed)

Created:
4 years, 10 months ago by vogelheim
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

DEPS for gn, used by 'gclient runhooks' to sync gn in buildtools/. R=machenbach@chromium.org BUG=chromium:474921 LOG=n Committed: https://crrev.com/3c56400e099a380d558d738d884668a413f28933 Cr-Commit-Position: refs/heads/master@{#33690}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M DEPS View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
vogelheim
btw, any tracking bug for V8 on gn things?
4 years, 10 months ago (2016-02-02 14:28:56 UTC) #1
Michael Achenbach
lgtm added bug, thanks!
4 years, 10 months ago (2016-02-02 16:14:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658223002/1
4 years, 10 months ago (2016-02-02 16:16:04 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/12652)
4 years, 10 months ago (2016-02-02 16:20:07 UTC) #7
Michael Achenbach
lgtm
4 years, 10 months ago (2016-02-02 20:01:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658223002/20001
4 years, 10 months ago (2016-02-02 20:02:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 20:07:50 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 20:08:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c56400e099a380d558d738d884668a413f28933
Cr-Commit-Position: refs/heads/master@{#33690}

Powered by Google App Engine
This is Rietveld 408576698