Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1658183002: WebRTC: Build Chromium with codecs (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, hbos_chromium
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

WebRTC: Build Chromium with codecs In order to build and test the OpenH264 codec, we need to pass additional GYP_DEFINES variables to our bots. These are already used by several bots in Chromium, but mainly by the GPU team. OpenH264 is not yet built when they're defined, but the plan is to make it so soon, so we want to ensure we're building with it since Chromium tests marked as MANUAL_ are going to be added, which only run in these WebRTC-controlled waterfalls. The GN bots are handled by the MB config in https://codereview.chromium.org/1654953004/ BUG=576201 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_chromium
I discussed with hbos@ to make use of the already existing property called proprietary_codecs instead ...
4 years, 10 months ago (2016-02-02 13:33:17 UTC) #4
phoglund_chromium
lgtm
4 years, 10 months ago (2016-02-02 13:36:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658183002/1
4 years, 10 months ago (2016-02-02 13:42:56 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 13:55:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298518

Powered by Google App Engine
This is Rietveld 408576698