chrome/browser/resources/pdf/pdf.js - Issue 165813004: Implement "go to page" functionality in out of process PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 165813004: Implement "go to page" functionality in out of process PDF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index 2908ba99bd688f9c387b901430007d3f0d265229..27a77a5bc0cbfb5c77273019c85885d85110d3a3 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -62,7 +62,9 @@ function handleMessage(message) {

viewerPageIndicator.initialFadeIn();

viewerToolbar.initialFadeIn();

} else if (message.data.type == 'loadProgress') {

- updateProgress(message.data['progress']);

+ updateProgress(message.data.progress);

+ } else if (message.data.type == 'goToPage') {

arv (Not doing code reviews) 2014/02/19 02:18:08 Maybe use a switch instead?

raymes 2014/02/19 03:24:35 Done.

+ viewport.goToPage(message.data.page);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »