Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 165813004: Implement "go to page" functionality in out of process PDF (Closed)

Created:
6 years, 10 months ago by raymes
Modified:
6 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Implement "go to page" functionality in out of process PDF The page can receive messages from the plugin that instruct it to scroll to a particular page. BUG=303491 R=arv@chromium.org, koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252178

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 3 4 1 chunk +14 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
raymes
6 years, 10 months ago (2014-02-18 06:44:45 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 10 months ago (2014-02-18 07:13:24 UTC) #2
raymes
+arv for OWNERS
6 years, 10 months ago (2014-02-19 00:23:52 UTC) #3
arv (Not doing code reviews)
LGTM with nit https://codereview.chromium.org/165813004/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/165813004/diff/1/chrome/browser/resources/pdf/pdf.js#newcode66 chrome/browser/resources/pdf/pdf.js:66: } else if (message.data.type == 'goToPage') ...
6 years, 10 months ago (2014-02-19 02:18:08 UTC) #4
raymes
https://codereview.chromium.org/165813004/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/165813004/diff/1/chrome/browser/resources/pdf/pdf.js#newcode66 chrome/browser/resources/pdf/pdf.js:66: } else if (message.data.type == 'goToPage') { On 2014/02/19 ...
6 years, 10 months ago (2014-02-19 03:24:35 UTC) #5
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 10 months ago (2014-02-19 23:49:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/165813004/130001
6 years, 10 months ago (2014-02-20 01:18:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 01:18:48 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/pdf/index.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-20 01:18:49 UTC) #9
raymes
6 years, 10 months ago (2014-02-20 04:36:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 manually as r252178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698