Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1658123002: [intrinsics] Remove %_IsFunction inline intrinsic. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Remove %_IsFunction inline intrinsic. There's no point in having %_IsFunction as inline intrinsic, as it is only used in non performance critical code, which is already full of runtime calls anyway, so %IsFunction will do the trick as well. R=yangguo@chromium.org Committed: https://crrev.com/8c04a35c83d70159606c0d14b96f819a9fa88545 Cr-Commit-Position: refs/heads/master@{#33660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -272 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -44 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/constant-fold-control-instructions.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-02 08:42:24 UTC) #1
Benedikt Meurer
Hey Yang, As discussed offline; no need to hyper-optimize the slow case. Please take a ...
4 years, 10 months ago (2016-02-02 08:42:50 UTC) #2
Yang
On 2016/02/02 08:42:50, Benedikt Meurer wrote: > Hey Yang, > > As discussed offline; no ...
4 years, 10 months ago (2016-02-02 08:52:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658123002/1
4 years, 10 months ago (2016-02-02 08:54:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 09:13:38 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 09:14:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c04a35c83d70159606c0d14b96f819a9fa88545
Cr-Commit-Position: refs/heads/master@{#33660}

Powered by Google App Engine
This is Rietveld 408576698