IndexedDB: Eliminate interfaces for IndexedDB{Factory,Database,Cursor}

IndexedDB: Eliminate interfaces for IndexedDB{Factory,Database,Cursor}

On the Blink side, the back-end types had interfaces which could also
be implemented by proxy objects. In the Chromium back-end this is
not necessary, so delete the interfaces and rename the impls.

BUG=234278
R=alecflett@chromium.org, darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204857

[jsbell, 2013-06-06 20:08:23]

alecflett@ - you reviewed this already as a different CL, just re-uploaded to
get around some reitveld issue. Can you L*G*T*M stamp it again?

darin@ - OWNERS review of the content/content_browser.gypi?

[darin (slow to review), 2013-06-06 21:23:57]

LGTM for content/content_browser.gypi

[alecflett, 2013-06-06 21:53:41]

lgtm

[commit-bot: I haz the power, 2013-06-06 21:57:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/16581002/1001

[commit-bot: I haz the power, 2013-06-06 23:41:16]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-07 00:26:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/16581002/19001

[commit-bot: I haz the power, 2013-06-07 09:27:07]

Failed to apply patch for content/browser/indexed_db/indexed_db_factory.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         content/browser/indexed_db/indexed_db_factory.cc
  Copied content/browser/indexed_db/indexed_db_factory_impl.cc ->
content/browser/indexed_db/indexed_db_factory.cc
  patching file content/browser/indexed_db/indexed_db_factory.cc
  Hunk #2 FAILED at 39.
  1 out of 7 hunks FAILED -- saving rejects to file
content/browser/indexed_db/indexed_db_factory.cc.rej

Patch:   NR 
content/browser/indexed_db/indexed_db_factory_impl.cc->content/browser/indexed_db/indexed_db_factory.cc
Index: content/browser/indexed_db/indexed_db_factory.cc
diff --git a/content/browser/indexed_db/indexed_db_factory_impl.cc
b/content/browser/indexed_db/indexed_db_factory.cc
similarity index 84%
rename from content/browser/indexed_db/indexed_db_factory_impl.cc
rename to content/browser/indexed_db/indexed_db_factory.cc
index
4a76f7451e2e4d4b278e102585ba0bb868a1a4a1..037bee2ec1dee6584a3645ba0c8419a1df4c4cc6
100644
--- a/content/browser/indexed_db/indexed_db_factory_impl.cc
+++ b/content/browser/indexed_db/indexed_db_factory.cc
@@ -2,12 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/browser/indexed_db/indexed_db_factory_impl.h"
+#include "content/browser/indexed_db/indexed_db_factory.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
-#include "content/browser/indexed_db/indexed_db_database_impl.h"
+#include "content/browser/indexed_db/indexed_db_database.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 #include "third_party/WebKit/public/platform/WebIDBDatabaseException.h"
@@ -39,41 +39,41 @@ static string16 ComputeUniqueIdentifier(const string16&
name,
   return ComputeFileIdentifier(database_identifier) + name;
 }
 
-IndexedDBFactoryImpl::IndexedDBFactoryImpl() {}
+IndexedDBFactory::IndexedDBFactory() {}
 
-IndexedDBFactoryImpl::~IndexedDBFactoryImpl() {}
+IndexedDBFactory::~IndexedDBFactory() {}
 
-void IndexedDBFactoryImpl::RemoveIDBDatabaseBackend(
+void IndexedDBFactory::RemoveIDBDatabaseBackend(
     const string16& unique_identifier) {
   DCHECK(database_backend_map_.find(unique_identifier) !=
          database_backend_map_.end());
   database_backend_map_.erase(unique_identifier);
 }
 
-void IndexedDBFactoryImpl::GetDatabaseNames(
+void IndexedDBFactory::GetDatabaseNames(
     scoped_refptr<IndexedDBCallbacksWrapper> callbacks,
     const string16& database_identifier,
     const base::FilePath& data_directory) {
-  IDB_TRACE("IndexedDBFactoryImpl::get_database_names");
+  IDB_TRACE("IndexedDBFactory::get_database_names");
   scoped_refptr<IndexedDBBackingStore> backing_store =
       OpenBackingStore(database_identifier, data_directory);
   if (!backing_store) {
-    callbacks->OnError(IndexedDBDatabaseError(
-        WebKit::WebIDBDatabaseExceptionUnknownError,
-        "Internal error opening backing store for "
-        "indexed_db.webkit_get_database_names."));
+    callbacks->OnError(
+        IndexedDBDatabaseError(WebKit::WebIDBDatabaseExceptionUnknownError,
+                               "Internal error opening backing store for "
+                               "indexed_db.webkit_get_database_names."));
     return;
   }
 
   callbacks->OnSuccess(backing_store->GetDatabaseNames());
 }
 
-void IndexedDBFactoryImpl::DeleteDatabase(
+void IndexedDBFactory::DeleteDatabase(
     const string16& name,
     scoped_refptr<IndexedDBCallbacksWrapper> callbacks,
     const string16& database_identifier,
     const base::FilePath& data_directory) {
-  IDB_TRACE("IndexedDBFactoryImpl::delete_database");
+  IDB_TRACE("IndexedDBFactory::delete_database");
   const string16 unique_identifier =
       ComputeUniqueIdentifier(name, database_identifier);
 
@@ -97,9 +97,8 @@ void IndexedDBFactoryImpl::DeleteDatabase(
     return;
   }
 
-  scoped_refptr<IndexedDBDatabaseImpl> database_backend =
-      IndexedDBDatabaseImpl::Create(
-          name, backing_store.get(), this, unique_identifier);
+  scoped_refptr<IndexedDBDatabase> database_backend =
IndexedDBDatabase::Create(
+      name, backing_store.get(), this, unique_identifier);
   if (!database_backend) {
     callbacks->OnError(IndexedDBDatabaseError(
         WebKit::WebIDBDatabaseExceptionUnknownError,
@@ -113,7 +112,7 @@ void IndexedDBFactoryImpl::DeleteDatabase(
   database_backend_map_.erase(unique_identifier);
 }
 
-scoped_refptr<IndexedDBBackingStore> IndexedDBFactoryImpl::OpenBackingStore(
+scoped_refptr<IndexedDBBackingStore> IndexedDBFactory::OpenBackingStore(
     const string16& database_identifier,
     const base::FilePath& data_directory) {
   const string16 file_identifier = ComputeFileIdentifier(database_identifier);
@@ -149,7 +148,7 @@ scoped_refptr<IndexedDBBackingStore>
IndexedDBFactoryImpl::OpenBackingStore(
   return 0;
 }
 
-void IndexedDBFactoryImpl::Open(
+void IndexedDBFactory::Open(
     const string16& name,
     int64 version,
     int64 transaction_id,
@@ -157,11 +156,11 @@ void IndexedDBFactoryImpl::Open(
     scoped_refptr<IndexedDBDatabaseCallbacksWrapper> database_callbacks,
     const string16& database_identifier,
     const base::FilePath& data_directory) {
-  IDB_TRACE("IndexedDBFactoryImpl::open");
+  IDB_TRACE("IndexedDBFactory::open");
   const string16 unique_identifier =
       ComputeUniqueIdentifier(name, database_identifier);
 
-  scoped_refptr<IndexedDBDatabaseImpl> database_backend;
+  scoped_refptr<IndexedDBDatabase> database_backend;
   IndexedDBDatabaseMap::iterator it =
       database_backend_map_.find(unique_identifier);
   if (it == database_backend_map_.end()) {
@@ -175,7 +174,7 @@ void IndexedDBFactoryImpl::Open(
       return;
     }
 
-    database_backend = IndexedDBDatabaseImpl::Create(
+    database_backend = IndexedDBDatabase::Create(
         name, backing_store.get(), this, unique_identifier);
     if (!database_backend) {
       callbacks->OnError(IndexedDBDatabaseError(

[jsbell, 2013-06-07 16:32:38]

Committed patchset #4 manually as r204857 (presubmit successful).