Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl

Issue 1658073002: ServiceWorker: Implement attributes of ExtendableMessageEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address falken's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl
index 30aee99e318e92c31f4e6c52a4a4f5171174dee0..171231efdacdd6cfe7c98abc93c715662414a43f 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl
+++ b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl
@@ -9,10 +9,9 @@
Exposed=ServiceWorker,
RuntimeEnabled=ServiceWorkerExtendableMessageEvent,
] interface ExtendableMessageEvent : ExtendableEvent {
- // TODO(nhiroki): Implement these attributes (crbug.com/543198).
- // readonly attribute any data;
- // readonly attribute DOMString origin;
- // readonly attribute DOMString lastEventId;
- // [SameObject] readonly attribute (Client or ServiceWorker or MessagePort)? source;
- // [SameObject] readonly attribute MessagePort[]? ports;
+ [Custom=Getter] readonly attribute any data;
+ readonly attribute DOMString origin;
+ readonly attribute DOMString lastEventId;
+ [SameObject] readonly attribute (Client or ServiceWorker or MessagePort)? source;
+ [SameObject] readonly attribute MessagePort[]? ports;
};

Powered by Google App Engine
This is Rietveld 408576698