third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl - Issue 1658073002: ServiceWorker: Implement attributes of ExtendableMessageEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl

Issue 1658073002: ServiceWorker: Implement attributes of ExtendableMessageEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address falken's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl

index 30aee99e318e92c31f4e6c52a4a4f5171174dee0..171231efdacdd6cfe7c98abc93c715662414a43f 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl

+++ b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl

@@ -9,10 +9,9 @@

Exposed=ServiceWorker,

RuntimeEnabled=ServiceWorkerExtendableMessageEvent,

] interface ExtendableMessageEvent : ExtendableEvent {

- // TODO(nhiroki): Implement these attributes (crbug.com/543198).

- // readonly attribute any data;

- // readonly attribute DOMString origin;

- // readonly attribute DOMString lastEventId;

- // [SameObject] readonly attribute (Client or ServiceWorker or MessagePort)? source;

- // [SameObject] readonly attribute MessagePort[]? ports;

+ [Custom=Getter] readonly attribute any data;

+ readonly attribute DOMString origin;

+ readonly attribute DOMString lastEventId;

+ [SameObject] readonly attribute (Client or ServiceWorker or MessagePort)? source;

+ [SameObject] readonly attribute MessagePort[]? ports;

};