third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp - Issue 1658073002: ServiceWorker: Implement attributes of ExtendableMessageEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp

Issue 1658073002: ServiceWorker: Implement attributes of ExtendableMessageEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address falken's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni » ('j') | third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/custom/V8ServiceWorkerMessageEventCustom.cpp b/third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp

similarity index 76%

copy from third_party/WebKit/Source/bindings/modules/v8/custom/V8ServiceWorkerMessageEventCustom.cpp

copy to third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp

index 7ca9fcd39cf0613df783ff1b26ab008044b0a9f1..ced0bf35a072e90255f1a98ba75e348053cfbeb1 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/custom/V8ServiceWorkerMessageEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp

@@ -1,17 +1,17 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "bindings/modules/v8/V8ServiceWorkerMessageEvent.h"

+#include "bindings/modules/v8/V8ExtendableMessageEvent.h"

#include "bindings/core/v8/SerializedScriptValue.h"

#include "bindings/core/v8/V8HiddenValue.h"

namespace blink {

-void V8ServiceWorkerMessageEvent::dataAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

+void V8ExtendableMessageEvent::dataAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- ServiceWorkerMessageEvent* event = V8ServiceWorkerMessageEvent::toImpl(info.Holder());

+ ExtendableMessageEvent* event = V8ExtendableMessageEvent::toImpl(info.Holder());

v8::Isolate* isolate = info.GetIsolate();

ScriptState* scriptState = ScriptState::current(isolate);

v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(scriptState, info.Holder(), V8HiddenValue::data(isolate));