ServiceWorker: Implement attributes of ExtendableMessageEvent

third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp

-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "bindings/modules/v8/V8ServiceWorkerMessageEvent.h"
+#include "bindings/modules/v8/V8ExtendableMessageEvent.h"
 
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/V8HiddenValue.h"
 
 namespace blink {
 
-void V8ServiceWorkerMessageEvent::dataAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
+void V8ExtendableMessageEvent::dataAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    ServiceWorkerMessageEvent* event = V8ServiceWorkerMessageEvent::toImpl(info.Holder());

[bashi, 2016/02/10 00:38:55]

It seems that ServiceWorkerMessageEvent also causes memory leak...

+    ExtendableMessageEvent* event = V8ExtendableMessageEvent::toImpl(info.Holder());

[bashi, 2016/02/10 00:38:55]

Please refer V8CustomEvent::detailAttributeGetterCustom() to see how to
implement a getter for "any" types. We should consider where the |data| comes
from and shouldn't expose it to different worlds.

[nhiroki, 2016/02/10 08:08:57]

Done.

     v8::Isolate* isolate = info.GetIsolate();
     ScriptState* scriptState = ScriptState::current(isolate);
     v8::Local<v8::Value> result = V8HiddenValue::getHiddenValue(scriptState, info.Holder(), V8HiddenValue::data(isolate));
 
     if (!result.IsEmpty()) {
         v8SetReturnValue(info, result);
         return;
     }
 
     v8::Local<v8::Value> data;
     if (SerializedScriptValue* serializedValue = event->serializedData()) {
         MessagePortArray ports = event->ports();
         data = serializedValue->deserialize(isolate, &ports);
     } else {
         data = event->data().v8ValueFor(scriptState);
     }
     if (data.IsEmpty())
         data = v8::Null(isolate);
     V8HiddenValue::setHiddenValue(scriptState, info.Holder(), V8HiddenValue::data(isolate), data);
     v8SetReturnValue(info, data);
 }
 
 } // namespace blink