third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp - Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-tracks-to-blink

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.idl ('K') | « third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.idl ('k') | third_party/WebKit/Source/modules/mediasource/SourceBufferTrackBaseSupplement.h » ('j') | third_party/WebKit/Source/modules/mediasource/SourceBufferTrackBaseSupplement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

index 0a84c2156632aebe053970ffb518f7d23aee4690..4b0d2df55a002177bac8556ab70cebebef930bd2 100644

--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

@@ -48,6 +48,7 @@

#include "core/html/track/VideoTrackList.h"

#include "core/streams/Stream.h"

#include "modules/mediasource/MediaSource.h"

+#include "modules/mediasource/SourceBufferTrackBaseSupplement.h"

#include "platform/Logging.h"

#include "platform/TraceEvent.h"

#include "public/platform/WebSourceBuffer.h"

@@ -532,6 +533,7 @@ std::vector<WebMediaPlayer::TrackId> SourceBuffer::initializationSegmentReceived

AudioTrack* audioTrack = nullptr;

if (!m_firstInitializationSegmentReceived) {

audioTrack = AudioTrack::create(id, kind, label, language, false);

+ new SourceBufferTrackBaseSupplement(*audioTrack, this);

audioTracks().add(audioTrack);

m_source->mediaElement()->audioTracks().add(audioTrack);

} else {

@@ -544,6 +546,7 @@ std::vector<WebMediaPlayer::TrackId> SourceBuffer::initializationSegmentReceived

VideoTrack* videoTrack = nullptr;

if (!m_firstInitializationSegmentReceived) {

videoTrack = VideoTrack::create(id, kind, label, language, false);

+ new SourceBufferTrackBaseSupplement(*videoTrack, this);

videoTracks().add(videoTrack);

m_source->mediaElement()->videoTracks().add(videoTrack);

} else {