third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.idl - Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.idl

Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-tracks-to-blink

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.cpp ('k') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp » ('j') | third_party/WebKit/Source/modules/mediasource/SourceBufferTrackBaseSupplement.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/media-source/#audio-track-extensions

	6 [

	7 GarbageCollected,

	8 ImplementedAs=SourceBufferTrackBaseSupplement,
	philipj_slow 2016/04/05 14:56:11 If you make the other suggested change, I think yo If you make the other suggested change, I think you could also consider dropping this, and instead just having AudioTrackSourceBuffer.h with a single static method that does return from(someContext).sourceBuffer() instead.
	9 RuntimeEnabled=AudioVideoTracks

	10 ] partial interface AudioTrack {

	11 readonly attribute SourceBuffer? sourceBuffer;

	12 };

OLD	NEW