third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.h - Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.h

Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-tracks-to-blink

Patch Set: Make A/V track lists plain members in SourceBuffer Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/VideoTrackList.h ('k') | third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.cpp » ('j') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef AudioTrackSourceBuffer_h

	6 #define AudioTrackSourceBuffer_h

	7

	8 #include "modules/mediasource/SourceBufferTrackBaseSupplement.h"

	9

	10 namespace blink {

	11

	12 class AudioTrack;

	13 class SourceBuffer;

	14

	15 class AudioTrackSourceBuffer final : public SourceBufferTrackBaseSupplement {
	philipj_slow 2016/03/10 13:12:17 Can this be simplified even further? It ought to b Can this be simplified even further? It ought to be possible to have class AudioTrackSourceBuffer { static SourceBuffer* sourceBuffer(AudioTrack&); }; where the implementation cast AudioTrack& to TrackBase& and calls into a shared "static SourceBuffer* TrackBase::sourceBuffer(TrackBase&)" that's used for both audio and video tracks. I tried to apply the patch locally to try it out myself first, but the CL doesn't apply any longer. Can you rebase? servolk 2016/03/11 02:00:57 Yep. In fact we don't even need the sourceBuffer m Show quoted text On 2016/03/10 13:12:17, philipj_UTC7 wrote: > Can this be simplified even further? It ought to be possible to have > > class AudioTrackSourceBuffer { > static SourceBuffer* sourceBuffer(AudioTrack&); > }; > > where the implementation cast AudioTrack& to TrackBase& and calls into a shared > "static SourceBuffer* TrackBase::sourceBuffer(TrackBase&)" that's used for both > audio and video tracks. > > I tried to apply the patch locally to try it out myself first, but the CL > doesn't apply any longer. Can you rebase? Yep. In fact we don't even need the sourceBuffer method here, since it's exactly the same for A and V cases. And we can remove the constructors that do the implicit casting from A/V tracks to TrackBase. Then we are left with just two empty classes that are descendants of SourceBufferTrackBaseSupplement, and we can just get rid of these two classes completely and instead just use ImplementedAs=SourceBufferTrackBaseSupplement in the .idl files.
	16 public:

	17 explicit AudioTrackSourceBuffer(AudioTrack&, SourceBuffer*);

	18 };

	19

	20 } // namespace blink

	21

	22 #endif

OLD	NEW