third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.idl - Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.idl

Issue 1658033002: Add SourceBuffer implementations of Audio/VideoTracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-tracks-to-blink

Patch Set: Make Audio/VideoTrackSB finalizable again Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.h ('K') | « third_party/WebKit/Source/modules/mediasource/AudioTrackSourceBuffer.cpp ('k') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/media-source/#audio-track-extensions

	6 [RuntimeEnabled=AudioVideoTracks] partial interface AudioTrack {
	philipj_slow 2016/02/26 13:36:54 Please format like this: [ RuntimeEnabled=Audi Please format like this: [ RuntimeEnabled=AudioVideoTracks, ] partial interface ... That's the norm, probably because it makes diffs when adding/removing extended attributes smaller. Also a blank line after the URL, at least I've done that almost everywhere. servolk 2016/03/03 03:39:26 Done. Show quoted text On 2016/02/26 13:36:54, philipj_UTC7 wrote: > Please format like this: > [ > RuntimeEnabled=AudioVideoTracks, > ] partial interface ... > > That's the norm, probably because it makes diffs when adding/removing extended > attributes smaller. Also a blank line after the URL, at least I've done that > almost everywhere. Done.
	7 readonly attribute SourceBuffer? sourceBuffer;

	8 };

OLD	NEW