Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4023)

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry.cc

Issue 1657933003: Fixes the interactive default browser UX for policy setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt comments 2 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/custom_handlers/protocol_handler_registry.cc
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry.cc b/chrome/browser/custom_handlers/protocol_handler_registry.cc
index 1bce59dda7c2c5e8df28385a0fefaae1238cf010..fbd7de7b87f84e9449ead5e3a2ac0248f827be9c 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry.cc
+++ b/chrome/browser/custom_handlers/protocol_handler_registry.cc
@@ -261,20 +261,11 @@ void ProtocolHandlerRegistry::DefaultClientObserver::SetDefaultWebClientUIState(
}
}
-bool ProtocolHandlerRegistry::DefaultClientObserver::
- IsInteractiveSetDefaultPermitted() {
- return true;
-}
-
void ProtocolHandlerRegistry::DefaultClientObserver::SetWorker(
ShellIntegration::DefaultProtocolClientWorker* worker) {
worker_ = worker;
}
-bool ProtocolHandlerRegistry::DefaultClientObserver::IsOwnedByWorker() {
- return true;
-}
-
// Delegate --------------------------------------------------------------------
ProtocolHandlerRegistry::Delegate::~Delegate() {}
@@ -303,7 +294,8 @@ ShellIntegration::DefaultProtocolClientWorker*
ProtocolHandlerRegistry::Delegate::CreateShellWorker(
ShellIntegration::DefaultWebClientObserver* observer,
const std::string& protocol) {
- return new ShellIntegration::DefaultProtocolClientWorker(observer, protocol);
+ return new ShellIntegration::DefaultProtocolClientWorker(observer, protocol,
+ true);
Nico 2016/02/09 03:01:31 I'd discourage boolean parameters as they make it
Patrick Monette 2016/02/09 17:15:05 Done.
}
ProtocolHandlerRegistry::DefaultClientObserver*

Powered by Google App Engine
This is Rietveld 408576698