Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 1657933003: Fixes the interactive default browser UX for policy setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index d8b9bc6ec6df5e9c92024f949453409e9a932d66..cf8af81b5bfcd5efe93326cd394c69518f98410b 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -1197,7 +1197,13 @@ void BrowserProcessImpl::CreateGCMDriver() {
void BrowserProcessImpl::ApplyDefaultBrowserPolicy() {
if (local_state()->GetBoolean(prefs::kDefaultBrowserSettingEnabled)) {
scoped_refptr<shell_integration::DefaultWebClientWorker>
- set_browser_worker = new shell_integration::DefaultBrowserWorker(NULL);
+ set_browser_worker = new shell_integration::DefaultBrowserWorker(
+ nullptr,
+ /*delete_observer=*/false);
Nico 2016/02/10 17:33:58 add a comment where the deletino happens
Patrick Monette 2016/02/10 20:44:42 Done.
+ // The user interaction must always be disabled when applying the default
+ // browser policy since it is done at each browser startup and the result
+ // of the interaction cannot be forced.
+ set_browser_worker->set_interactive_permitted(false);
set_browser_worker->StartSetAsDefault();
}
}

Powered by Google App Engine
This is Rietveld 408576698