Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerTest.cpp

Issue 1657883002: Fix leak PaintLayerReflectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..0b9814986dc3a65bb59161f124d133a53eaa676f
--- /dev/null
+++ b/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/paint/PaintLayer.h"
+
+#include "core/layout/LayoutReplica.h"
+#include "core/layout/LayoutTestHelper.h"
+
+namespace blink {
+
+class PaintLayerTest : public RenderingTest {
+};
+
+TEST_F(PaintLayerTest, ReflectionLeak)
+{
+ setBodyInnerHTML("<div id='div' style='-webkit-box-reflect: above'>test</div>");
+ HTMLElement* div = toHTMLElement(document().getElementById(AtomicString("div")));
+ PaintLayerReflectionInfo* reflectionInfo = div->layoutBoxModelObject()->layer()->reflectionInfo();
+ ASSERT_TRUE(reflectionInfo);
+ LayoutReplica* replica = reflectionInfo->reflection();
+ ASSERT_TRUE(replica);
+
+ div->setAttribute(HTMLNames::styleAttr, "-webkit-box-reflect: below");
+ document().view()->updateAllLifecyclePhases();
+
+ PaintLayerReflectionInfo* newReflectionInfo = div->layoutBoxModelObject()->layer()->reflectionInfo();
+ ASSERT_TRUE(newReflectionInfo);
+ EXPECT_NE(reflectionInfo, newReflectionInfo);
+ LayoutReplica* newReplica = newReflectionInfo->reflection();
+ ASSERT_TRUE(newReplica);
+ EXPECT_NE(replica, newReplica);
+
+ // LeakDetector should report no leaks of LayoutReplica or PaintLayer.
+}
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698