third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 1657883002: Fix leak PaintLayerReflectionInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1657883002: Fix leak PaintLayerReflectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index 646d3af759cb51a52af0cf605281e262e77abb04..b31f3dbdf56d7bcf88e6b4933676127694c39383 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -203,9 +203,6 @@ PaintLayer::~PaintLayer()

clearCompositedLayerMapping(true);

- if (PaintLayerReflectionInfo* reflectionInfo = this->reflectionInfo())

- reflectionInfo->destroy();

if (m_scrollableArea)

m_scrollableArea->dispose();

}

@@ -1419,7 +1416,6 @@ void PaintLayer::updateReflectionInfo(const ComputedStyle* oldStyle)

ensureRareData().reflectionInfo = adoptPtr(new PaintLayerReflectionInfo(*layoutBox()));

m_rareData->reflectionInfo->updateAfterStyleChange(oldStyle);

} else if (m_rareData && m_rareData->reflectionInfo) {

- m_rareData->reflectionInfo->destroy();

m_rareData->reflectionInfo = nullptr;

}