Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1657863004: [turbofan] Introduce proper ObjectIsReceiver operator. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce proper ObjectIsReceiver operator. Avoid the hacking in JSIntrinsicLowering and provide a proper simplified operator ObjectIsReceiver instead that is used to implement %_IsJSReceiver which is used by our JavaScript builtins and the JSInliner. R=jarin@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/6b2001b6b7c7152c566004e78aa523e1c9d5c82a Cr-Commit-Position: refs/heads/master@{#33675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -115 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +1 line, -40 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +54 lines, -10 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 4 chunks +38 lines, -11 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/compiler/double-array-to-global.js View 1 chunk +8 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 2 chunks +6 lines, -47 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-02 10:53:31 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the patch you helped me. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-02 10:54:00 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-02 11:38:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657863004/1
4 years, 10 months ago (2016-02-02 11:41:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 11:42:48 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 11:43:13 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6b2001b6b7c7152c566004e78aa523e1c9d5c82a
Cr-Commit-Position: refs/heads/master@{#33675}

Powered by Google App Engine
This is Rietveld 408576698